Replacing udf_metadata_key from string_literal to ID_LITERAL

modified: evadb/parser/evadb.lark Removed .value from key_value_pair[0] post the change in type modified: evadb/parser/lark_visitor/_functions.py Replaced string key to ID_LITERAL in test query modified: test/unit_tests/parser/test_parser.py
georgia-tech-db · Sep 1, 2023 · adbd3f5 · adbd3f5
1 parent 66685f0
commit adbd3f5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/evadb/parser/evadb.lark b/evadb/parser/evadb.lark
@@ -49,7 +49,7 @@ udf_impl: string_literal
 
 udf_metadata: udf_metadata_key udf_metadata_value
 
-udf_metadata_key: string_literal
+udf_metadata_key: uid 
 
 udf_metadata_value: string_literal | decimal_literal
 
@@ -207,7 +207,7 @@ simple_id: ID
 
 dotted_id: DOT_ID | "." uid
 
-//    Literals
+//    Literalss
 
 string_literal: STRING_LITERAL
 

diff --git a/evadb/parser/lark_visitor/_functions.py b/evadb/parser/lark_visitor/_functions.py
@@ -97,7 +97,8 @@ def create_udf(self, tree):
                     value = key_value_pair[1]
                     if isinstance(value, ConstantValueExpression):
                         value = value.value
-                    metadata.append((key_value_pair[0].value, value)),
+                    # Removing .value from key_value_pair[0] since key is now an ID_LITERAL
+                    metadata.append((key_value_pair[0], value)),
 
         return CreateUDFStatement(
             udf_name,

diff --git a/test/unit_tests/parser/test_parser.py b/test/unit_tests/parser/test_parser.py
@@ -662,7 +662,7 @@ def test_create_udf_statement(self):
                   OUTPUT (Labels NDARRAY STR(10), Bbox NDARRAY UINT8(10, 4))
                   TYPE  Classification
                   IMPL  'data/fastrcnn.py'
-                  "KEY" "VALUE";
+                  PREDICT "VALUE";
         """
 
         expected_cci = ColConstraintInfo()
@@ -690,7 +690,7 @@ def test_create_udf_statement(self):
             ],
             "Classification",
             None,
-            [("KEY", "VALUE")],
+            [("PREDICT", "VALUE")],
         )
         evadb_statement_list = parser.parse(create_udf_query)
         self.assertIsInstance(evadb_statement_list, list)