Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL Integration Bugs #1020

Closed
1 of 2 tasks
gaurav274 opened this issue Aug 31, 2023 · 1 comment · Fixed by #1019
Closed
1 of 2 tasks

MySQL Integration Bugs #1020

gaurav274 opened this issue Aug 31, 2023 · 1 comment · Fixed by #1019
Assignees
@jiashenC
Labels
Bug 🐞 EVA is not working as expected
Milestone
v0.3.5

Comments

@gaurav274
Copy link
Member

Search before asking

  • I have searched the EvaDB issues and found no similar bug report.

Bug

@rohithmulumudy - A few things need to be improved:

  • get_columns has to be updated - It should have the following two columns: name and dtype. The dtype should be a Python dtype and will default to str.
  • The init should have self.connection = None

Environment

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@gaurav274 gaurav274 added the Bug 🐞 EVA is not working as expected label Aug 31, 2023
@jiashenC
Copy link
Member

jiashenC commented Sep 1, 2023

#1019

@jiashenC jiashenC linked a pull request Sep 1, 2023 that will close this issue
feat: add CI for MySQL #1019
Merged
@xzdandy xzdandy added this to the v0.3.5 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiashenC jiashenC

Labels
Bug 🐞 EVA is not working as expected
Projects
EVA Public Roadmap ⚡🚀
Archived in project
Milestone
v0.3.5
Development

Successfully merging a pull request may close this issue.

feat: add CI for MySQL georgia-tech-db/evadb
3 participants
@xzdandy @jiashenC @gaurav274