-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native support for STRING_AGG #1393
base: staging
Are you sure you want to change the base?
Native support for STRING_AGG #1393
Conversation
script/test/test.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert the test.sh change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the access the permission is still changed. 100644 → 100755
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the unit tests they look good. I think we also need an integration test where we have the STRING_AGG
in a SQL query to verify that it works from end to end.
Can you send some code pointers on writing an integration test here? |
@ryanmle2001 Here
|
Related to issue #1331
Process: