Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Make symfony/console an explicit dependency #2315

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Jan 16, 2024

Relying on transitional dependencies (and their version constraints) is considered bad practice.

Related to #2312

@oliverklee oliverklee force-pushed the bugfix/symfony-dependency branch 2 times, most recently from cac715c to 438fd06 Compare January 16, 2024 21:38
@georgringer
Copy link
Owner

wanna fix the the conflict? awesome prs, thanks a ton!

@oliverklee oliverklee force-pushed the bugfix/symfony-dependency branch from 438fd06 to 22c9b6b Compare January 17, 2024 12:31
@oliverklee
Copy link
Contributor Author

Done.

@oliverklee oliverklee force-pushed the bugfix/symfony-dependency branch 3 times, most recently from b9dd91f to 09ee58a Compare January 22, 2024 19:08
@oliverklee oliverklee force-pushed the bugfix/symfony-dependency branch from 09ee58a to 157a711 Compare January 26, 2024 11:56
@oliverklee
Copy link
Contributor Author

@georgringer gentle ping :-)

Relying on transitional dependencies (and their version constraints)
is considered bad practice.

Related to georgringer#2312
@oliverklee oliverklee force-pushed the bugfix/symfony-dependency branch from 157a711 to ab0b2c1 Compare January 26, 2024 11:57
@georgringer georgringer merged commit 00550a8 into georgringer:main Jan 26, 2024
17 checks passed
@oliverklee oliverklee deleted the bugfix/symfony-dependency branch January 26, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants