Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small differences in JOH and JNO2 restart variables upon 14.3.0 restart #375

Open
lizziel opened this issue Jan 31, 2024 · 6 comments
Open
Assignees
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Restart Files Related to GCHP restart files

Comments

@lizziel
Copy link
Contributor

lizziel commented Jan 31, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Description of your issue or question

I am doing reproducibility tests of GCHP upon restart, meaning I am checking that all diagnostics and restart files are bit-for-bit reproducible regardless of how a run is broken up in time. Transport tracer simulation passes the test as do full chemistry diagnostic output (benchmark simulation). However, I am seeing small differences in some grid boxes for JNO2 and JOH in the restart file. This needs to be further investigated.

@lizziel lizziel added the category: Bug Something isn't working label Jan 31, 2024
@lizziel lizziel self-assigned this Jan 31, 2024
Copy link
Contributor

@lizziel: Wondering if these are from the PARANOx HEMCO extension. If so, that would explain it, as those would be REAL*4.

Copy link
Contributor

yantosca commented Jan 31, 2024

@lizziel: Indeed, these come from HEMCO. In GCClassic these fields would be saved to the HEMCO restart file, but in GCHP these are all saved to checkpoint/restarts. The arrays are of type ExtDat_2R, which use the Arr_2D_HP type.

     TYPE(ExtDat_2R),  POINTER :: JNO2        ! J-Value for NO2 [1/s]
     TYPE(ExtDat_2R),  POINTER :: JOH         ! J-Value for O3->OH  [1/s]

Also note; I believe the data are stored internally in hcox_paranox_mod.F90 as REAL*4. So even if the HEMCO precision hp is set to REAL\8, you would still get roundoff errors.

@lizziel
Copy link
Contributor Author

lizziel commented Jan 31, 2024

@yantosca, I don't think HEMCO is what is causing this. The JNO2 and JOH arrays are copied between the MAPL internal state and State_Chm%JNO2/State_Chm%JOH. The State_Chm arrays are used to set the arrays used in HEMCO, but they are not modified by HEMCO, and the values in State_Chm are set from the ZPJ arrays in fullchem_mod.F90 in GEOS-Chem:
GeosCore/fullchem_mod.F90:1613: State_Chm%JNO2(:,:) = State_Chm%Phot%ZPJ(1,State_Chm%Phot%RXN_NO2,:,:)

@lizziel
Copy link
Contributor Author

lizziel commented Jan 31, 2024

A quick test for this is to turn off paranox. This is not an urgent issue because GEOS does not use paranox and thus does not include JNO2 and JOH in the internal state.

@lizziel lizziel added the topic: Restart Files Related to GCHP restart files label Mar 25, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the issue from closing this issue.

@github-actions github-actions bot added the stale No recent activity on this issue label Nov 14, 2024
Copy link

Closing due to inactivity

@lizziel lizziel reopened this Nov 21, 2024
@lizziel lizziel added never stale Never label this issue as stale and removed stale No recent activity on this issue labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Restart Files Related to GCHP restart files
Projects
None yet
Development

No branches or pull requests

2 participants