Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist viewer type in the map configuration #8334

Closed
1 of 2 tasks
allyoucanmap opened this issue Jun 15, 2022 · 6 comments · Fixed by #8990 or #9012
Closed
1 of 2 tasks

Persist viewer type in the map configuration #8334

allyoucanmap opened this issue Jun 15, 2022 · 6 comments · Fixed by #8990 or #9012
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted C027-COMUNE_FI-2023-SUPPORT enhancement
Milestone

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Jun 15, 2022

Description

Use Case

Some map could contain layer only visible in a specific viewer, for example the 3D tiles layers that could be available only in a 3D scene (Cesium). In this specific case it would be nice to be able to save the map with the information related to the current map type in use to visualize the map in 3D at the next reload.


The switch mechanism between 2D/3D in the map viewer is related to the mapType path inside the viewer url and stored in the redux state. This information is not persisted in the map config.

  • Find a solution to store this property in the map config. Should we store it as 2D/3D flag or be explicit with the map type in use (openlayers, leaflet, cesium)? In some case we switch the 2d library based on device
    - [ ] Evaluate if it makes sense to deprecate the /viewer/:mapType/:mapId in favor of /viewer/:mapId where the mapType is managed only via config or internal state
    - [ ] Review if query params needs some adjustment based on previous improvement. In particular if we need to be explicit with a map_type param or guess the map type based on the query content

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information

see #8320 (review)

@tdipisa tdipisa added the 3D All issues related to the 3D rendering in CesiumJs label Jun 16, 2022
@tdipisa tdipisa assigned weberjavi and unassigned tdipisa Jun 21, 2022
@allyoucanmap allyoucanmap changed the title Review 2D/3D switch in the map viewer Persist viewer type in the map configuration Jun 23, 2022
@weberjavi
Copy link
Contributor

As discussed with @allyoucanmap It seems that there are (at least) two possible ways to persist matype (viewer) on map configuration.

One would be by storing the active map viewer type when the user saves the map; that is if the viewer is doing updates to the map and has the 3d (Cesium) viewer activated that would be the maptype stored in the config and hence the one that will be active next time the user opens the map. This implementation would be somehow implicit in the sense that there's no explicit action from the user to set the maptype and it is given by the last viewer in which changes have been stored.

Another way would be to have a section on the map settings for the user to set the default maptype (viewer) that would be used when the map loads. This option would be more explicit since the user would need to trigger a specific action in order to define this attribute of the map.

@tdipisa
Copy link
Member

tdipisa commented Jun 23, 2022

@weberjavi moving in blocked column for now, waiting for a decision from the core team.

@ElenaGallo
Copy link
Contributor

@allyoucanmap some notes after my tests:

1_ On dashboard, the zoom of the 2D map and 3D map is different if the two map are connected. Use this example.

zoom

2_ On dashboard, if a map is connected to a 3D map, it is no longer possible to zoom in/out the map independently.

Expected Result

ex.mov

Current Result

current.mov

3_ In the Geocarousel section of Geostory it is not possible to add a marker if the map is in 3D. Use this example.

mark.mov

4_ On dashboard and geostory, MS crashes if user tries to change style of 3D tiles or WFS layer.

crash.mov

@tdipisa
Copy link
Member

tdipisa commented Mar 15, 2023

@ElenaGallo thank you so much for reporting the above. Please create a dedicated issue for each point. @allyoucanmap I think at least some them should be fixed. Let's review together, in the meantime @ElenaGallo you can proceed with the creation of issues using the same project label and assigning issues to me and @allyoucanmap.
@ElenaGallo issue moved again in Test, if you have already tested this I think this issue can be moved in Done.

@tdipisa
Copy link
Member

tdipisa commented Mar 17, 2023

@ElenaGallo is this tested/accepted? Please mention about newly created issues with links as requested above in a new comment.

@ElenaGallo
Copy link
Contributor

Hi @tdipisa,
the issue has been tested, I close it and the new issues are: #9017 #9018 #9019 #9020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted C027-COMUNE_FI-2023-SUPPORT enhancement
Projects
None yet
4 participants