Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keplerian orbits not being computed on datasets anymore #107

Open
mauriciodev opened this issue Apr 18, 2024 · 0 comments
Open

Keplerian orbits not being computed on datasets anymore #107

mauriciodev opened this issue Apr 18, 2024 · 0 comments

Comments

@mauriciodev
Copy link
Contributor

If you read the nav data using georinex and pass it to keplerian.py, the set comparison doesn't work because sv is a dataframe, not a string. I checked the test suit and it seems that it's using a dict instead of a xarray object, so that's why it passes.
Code works as expected if we run:
sed -i -e 's/sv["sv"] in {"R", "S"}/sv["sv"] in ("R", "S")/g' /usr/local/lib/python3.10/dist-packages/georinex/keplerian.py

Please revert commit c3644ad on src/georinex/keplerian.py>
- if "sv" in sv and sv["sv"] in ("R", "S"):
+ if "sv" in sv and sv["sv"] in {"R", "S"}:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant