Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction history text cut short #1011

Closed
luckysori opened this issue Jul 26, 2023 · 5 comments · Fixed by #1054
Closed

Transaction history text cut short #1011

luckysori opened this issue Jul 26, 2023 · 5 comments · Fixed by #1054
Assignees
Labels

Comments

@luckysori
Copy link
Contributor

The new text accompanying entries such as the matching fee is not really readable atm.

image


Running on iPhone SE.

@luckysori luckysori added the UI label Jul 26, 2023
@Restioson
Copy link
Contributor

If you open the detailed balance view's tx/rx menu then you have a similar problem 😅

@Restioson
Copy link
Contributor

Restioson commented Jul 28, 2023

image

This is an issue on my android

@Restioson Restioson self-assigned this Jul 28, 2023
@Restioson Restioson added android and removed android labels Jul 28, 2023
@Restioson
Copy link
Contributor

Restioson commented Jul 28, 2023

Potential solution could be to change the text to just the type of event (fee, on-chain payment, off-chain payment, position open) , add some text wrapping to make sure that it's always displayed, and then add some kind of cue that shows that it can be expanded. Then, when the user clicks on it, they can get detailed info in a table, like the exact amount of sats (instead of just the rounded figure), exact time, order ID, other address, etc.

@Restioson
Copy link
Contributor

Restioson commented Jul 31, 2023

Possibly related: #346 #872

@luckysori
Copy link
Contributor Author

Potential solution could be to change the text to just the type of event (fee, on-chain payment, off-chain payment, position open) , add some text wrapping to make sure that it's always displayed, and then add some kind of cue that shows that it can be expanded. Then, when the user clicks on it, they can get detailed info in a table, like the exact amount of sats (instead of just the rounded figure), exact time, order ID, other address, etc.

Thanks for thinking about this!

I think for now it would be good enough to prioritise the type of event like you say. The rest of the information could appear on a pop-up screen or we could just expand the transaction history item in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants