Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist limit orders #227

Closed
Tracked by #972
bonomat opened this issue Mar 7, 2023 · 5 comments
Closed
Tracked by #972

Persist limit orders #227

bonomat opened this issue Mar 7, 2023 · 5 comments
Labels
maker Stale
Milestone
1.3.1

Comments

@bonomat
Copy link
Contributor

bonomat commented Mar 7, 2023 •
edited
Loading

The maker is currently not persisting anything, which means, on a restart, it won't remember anything.

This ticket is about storing

  • orders and their states

Once we have positions, we should also store them
@bonomat bonomat added the maker label Mar 7, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 25, 2023
@holzeis holzeis added this to the 1.0.22 milestone Jun 25, 2023
@holzeis
Copy link
Contributor

holzeis commented Jun 25, 2023 •
edited
Loading

@bonomat this ticket looks relevant for milestone 1.2.0, but lacks some description. May I ask you to add details or close the ticket?

@github-actions github-actions bot removed the Stale label Jun 26, 2023
@bonomat bonomat changed the title persist orders and position [maker] Persist orders Jun 26, 2023
@holzeis holzeis changed the title [maker] Persist orders Persist limit orders Jul 21, 2023
@bonomat bonomat mentioned this issue Jul 21, 2023
Closed
@luckysori
Copy link
Contributor

Once we have positions, we should also store them

We can do this as part of #973, or as a follow-up.

@bonomat bonomat modified the milestones: 1.3.0, 1.3.1 Aug 14, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 14, 2023
@bonomat bonomat removed the Stale label Sep 15, 2023
@bonomat bonomat mentioned this issue Sep 19, 2023
Merged
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maker Stale
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
3 participants
@bonomat @holzeis @luckysori