JIT - Channel Fee: LSP Flow #843
Assignees
Comments
Closed
|
Might be available in LDK 116 : lightningdevkit/rust-lightning#1999 |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Looks like we might need to wait for one more release. |
luckysori
added a commit
that referenced
this issue
Aug 18, 2023
Fixes #1087. We fix two issues here: - We no longer assume that the order-matching fee is constant. It actually depends on the state of the blockchain, which can change as we run the e2e tests (even if run sequentially!). - We wait for the app to confirm the payment before continuing with test assertions. Otherwise these tests can be flaky. The fact that the test needs to know about certain implementation details (e.g. that the order-matching fee is paid via a payment after the JIT channel is open) is not great, but it's pretty hard to know what fee will be charged from within the test before it is actually paid. This test will probably have to change when we address #843.
luckysori
added a commit
that referenced
this issue
Aug 18, 2023
Fixes #1087. We fix two issues here: - We no longer assume that the order-matching fee is constant. It actually depends on the state of the blockchain, which can change as we run the e2e tests (even if run sequentially!). - We wait for the app to confirm the payment before continuing with test assertions. Otherwise these tests can be flaky. The fact that the test needs to know about certain implementation details (e.g. that the order-matching fee is paid via a payment after the JIT channel is open) is not great, but it's pretty hard to know what fee will be charged from within the test before it is actually paid. This test will probably have to change when we address #843.
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up ticket from #577
LSP flow: there is work on Bolt X (TBD) which says that nodes may accept payments smaller than amounts in the invoice. Once this is done, we can subtract a channel fee from the payment amount same as Breez does. This is defined in LSPS2 of the upcoming LSP Spec and will find its way into bolts and all implementations soon. #393
The text was updated successfully, but these errors were encountered: