From ee866abf17dcf3efd0233421fa86be49cf57ebf7 Mon Sep 17 00:00:00 2001 From: Vineet Choudhary Date: Thu, 22 Dec 2016 16:47:54 +0530 Subject: [PATCH 1/6] Fixed IPA button enable at startup https://github.com/vineetchoudhary/AppBox-iOSAppsWirelessInstallation/issues/16 --- AppBox/ViewController/HomeViewController/HomeViewController.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppBox/ViewController/HomeViewController/HomeViewController.m b/AppBox/ViewController/HomeViewController/HomeViewController.m index 076bd2c2..c34ec697 100644 --- a/AppBox/ViewController/HomeViewController/HomeViewController.m +++ b/AppBox/ViewController/HomeViewController/HomeViewController.m @@ -685,7 +685,7 @@ -(void)viewStateForProgressFinish:(BOOL)finish{ [textFieldMessage setEnabled:(finish && buttonSendMail.state == NSOnState)]; //action button - [buttonAction setEnabled:finish]; + [self updateViewState]; } -(void)resetBuildOptions{ From c7716fa02551fcd47d8fa5070fcfd1ab5a984a86 Mon Sep 17 00:00:00 2001 From: Vineet Choudhary Date: Thu, 22 Dec 2016 17:33:49 +0530 Subject: [PATCH 2/6] Fixed teamid and build scheme when processed finished --- .../HomeViewController/HomeViewController.m | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/AppBox/ViewController/HomeViewController/HomeViewController.m b/AppBox/ViewController/HomeViewController/HomeViewController.m index c34ec697..94e020a0 100644 --- a/AppBox/ViewController/HomeViewController/HomeViewController.m +++ b/AppBox/ViewController/HomeViewController/HomeViewController.m @@ -38,14 +38,6 @@ - (void)viewDidLoad { //setup initial value [pathBuild setURL:[NSURL URLWithString:[@"~/Desktop" stringByExpandingTildeInPath]]]; [project setBuildDirectory: pathBuild.URL]; - - //setup team id - [comboTeamId removeAllItems]; - [allTeamIds enumerateObjectsUsingBlock:^(id _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) { - [comboTeamId addItemWithObjectValue:[obj valueForKey:abFullName]]; - }]; - - [self updateViewState]; } - (void)viewWillAppear{ @@ -662,7 +654,14 @@ -(void)viewStateForProgressFinish:(BOOL)finish{ //team id combo [comboTeamId setEnabled:finish]; - if (finish && comboTeamId.indexOfSelectedItem >= 0) [comboTeamId deselectItemAtIndex:comboTeamId.indexOfSelectedItem]; + if (finish){ + //setup team id + [comboTeamId removeAllItems]; + [comboTeamId setStringValue:abEmptyString]; + [allTeamIds enumerateObjectsUsingBlock:^(id _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) { + [comboTeamId addItemWithObjectValue:[obj valueForKey:abFullName]]; + }]; + } //build type combo [comboBuildType setEnabled:finish]; @@ -672,6 +671,7 @@ -(void)viewStateForProgressFinish:(BOOL)finish{ [comboBuildScheme setEnabled:finish]; if (finish){ if (comboBuildScheme.indexOfSelectedItem >= 0){ + [comboBuildScheme setStringValue:abEmptyString]; [comboBuildScheme deselectItemAtIndex:comboBuildType.indexOfSelectedItem]; } [comboBuildScheme removeAllItems]; From 4b93719857188666b0babdc6ce3ecf22a7c51619 Mon Sep 17 00:00:00 2001 From: Vineet Choudhary Date: Thu, 22 Dec 2016 18:45:42 +0530 Subject: [PATCH 3/6] Fixed drag-drop issue --- AppBox/ViewController/HomeViewController/HomeViewController.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/AppBox/ViewController/HomeViewController/HomeViewController.m b/AppBox/ViewController/HomeViewController/HomeViewController.m index 94e020a0..67eb1a07 100644 --- a/AppBox/ViewController/HomeViewController/HomeViewController.m +++ b/AppBox/ViewController/HomeViewController/HomeViewController.m @@ -97,7 +97,7 @@ - (IBAction)comboBuildTypeValueChanged:(NSComboBox *)sender { //IPA File Path Handler - (IBAction)ipaFilePathHandle:(NSPathControl *)sender { if (![project.fullPath isEqual:sender.URL]){ - project.ipaFullPath = sender.URL; + project.ipaFullPath = sender.URL.filePathURL; [self updateViewState]; } } @@ -380,6 +380,7 @@ - (void)getIPAInfoFromLocalURL:(NSURL *)ipaFileURL{ }]; }else{ [[AppDelegate appDelegate] addSessionLog:[NSString stringWithFormat:@"\n\n======\nFile Not Exist - %@\n======\n\n",fromPath]]; + [self viewStateForProgressFinish:YES]; } } From d6ab65a19b1ec9ef59c8b333467b02caca153886 Mon Sep 17 00:00:00 2001 From: Vineet Choudhary Date: Thu, 22 Dec 2016 18:53:06 +0530 Subject: [PATCH 4/6] Prepare for release --- AppBox/Info.plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppBox/Info.plist b/AppBox/Info.plist index 401a0d11..bb32095b 100644 --- a/AppBox/Info.plist +++ b/AppBox/Info.plist @@ -17,7 +17,7 @@ CFBundlePackageType APPL CFBundleShortVersionString - 0.9.5 + 0.9.6 CFBundleSignature ???? CFBundleURLTypes From 08c224e91afdad11db8d4530bea3e18bd2c784f2 Mon Sep 17 00:00:00 2001 From: Vineet Choudhary Date: Thu, 22 Dec 2016 19:48:01 +0530 Subject: [PATCH 5/6] Added live identifier --- AppBox/Info.plist | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/AppBox/Info.plist b/AppBox/Info.plist index bb32095b..679dc919 100644 --- a/AppBox/Info.plist +++ b/AppBox/Info.plist @@ -32,6 +32,16 @@ db-86tfx5bu3356fqo + + CFBundleTypeRole + Editor + CFBundleURLName + Dropbox-Live + CFBundleURLSchemes + + db-mzwu8mq9xdtilpr + + CFBundleVersion 1 From d6336146615209dc38d771453c1e6e319fce3d8b Mon Sep 17 00:00:00 2001 From: Vineet Choudhary Date: Thu, 22 Dec 2016 19:49:41 +0530 Subject: [PATCH 6/6] Fixed DropBox url scheme --- AppBox/Info.plist | 9 --------- 1 file changed, 9 deletions(-) diff --git a/AppBox/Info.plist b/AppBox/Info.plist index 679dc919..f95e1eed 100644 --- a/AppBox/Info.plist +++ b/AppBox/Info.plist @@ -30,15 +30,6 @@ CFBundleURLSchemes db-86tfx5bu3356fqo - - - - CFBundleTypeRole - Editor - CFBundleURLName - Dropbox-Live - CFBundleURLSchemes - db-mzwu8mq9xdtilpr