Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim long values in AppMaps #77

Open
dividedmind opened this issue Jan 12, 2024 · 1 comment
Open

Trim long values in AppMaps #77

dividedmind opened this issue Jan 12, 2024 · 1 comment

Comments

@dividedmind
Copy link
Collaborator

The AppMap specification says this about value fields:

string describing the object. This is not a strict JSON serialization, but rather a display string which is intended for the user. These strings should be trimmed in length to 100 characters.

appmap-node currently does no such trimming. Note this can be particularly inconvenient when eg. this is an object of a rich class with many methods. Perhaps it's worthwhile to filter the dump to only own properties. We want to make these 100 chars count.

@kgilpin
Copy link
Contributor

kgilpin commented Jan 12, 2024

Yes the agent is free to implement this limit in whatever makes the most sense. 100 characters is guidance - it’s important to have some limit to avoid outputting pathologically long strings and blowing up the map files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants