Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default config is wrong if there's a virtual env in the project #245

Open
apotterri opened this issue May 30, 2023 · 2 comments
Open

default config is wrong if there's a virtual env in the project #245

apotterri opened this issue May 30, 2023 · 2 comments
Labels
appmap-python bug Something isn't working

Comments

@apotterri
Copy link
Contributor

When appmap creates a default config for a project directory that contains a virtual environment, it includes all the packages installed in the venv. This isn't desirable and causes various failures.

If possible, it should detect a directory that's a venv and ignore it.

@dustinbyrne
Copy link
Contributor

What are the steps required to reproduce this? I've installed appmap in a new directory containing a venv with some packages, but the resulting appmap.yml only contains

appmap_dir: tmp/appmap
language: python
name: test
packages: []

@apotterri
Copy link
Contributor Author

IIRC, you need to create the venv in the project's root directory, and the venv directory name needs to not start with a ., and not be node_modules (not that any project would do the latter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appmap-python bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants