Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalized_path may be wrong if the path matches many potential routes #316

Open
dustinbyrne opened this issue Feb 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@dustinbyrne
Copy link
Contributor

dustinbyrne commented Feb 21, 2023

E.g. given the following routes.rb:

get 'api/users'
get ':team_slug/users'

It appears possible for a call to /api/users to return a normalized path of /:team_slug/users incorrectly when the path matches the route definition.

https://github.com/getappmap/appmap-ruby/blob/master/lib/appmap/handler/rails/request_handler.rb#L59-L66

@dustinbyrne dustinbyrne added the bug Something isn't working label Feb 21, 2023
@dustinbyrne
Copy link
Contributor Author

This may only occur due to URL rewriting in the client application. No X-Cascade headers were being set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant