Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Multi-language support #32

Merged
merged 70 commits into from
Apr 6, 2024

Conversation

robvanderleek
Copy link
Collaborator

No description provided.

@create-issue-branch create-issue-branch bot changed the title Issue 31 multi language support feat: ✨ Multi-language support Mar 10, 2024
Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codelimit-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 5:04pm

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 92.67982% with 115 lines in your changes are missing coverage. Please review.

Project coverage is 94.40%. Comparing base (6424204) to head (a8a4b03).
Report is 4 commits behind head on main.

❗ Current head a8a4b03 differs from pull request most recent head 8bf23c9. Consider uploading reports for the commit 8bf23c9 to get more accurate results

Files Patch % Lines
codelimit/common/utils.py 33.82% 45 Missing ⚠️
codelimit/common/Scanner.py 76.74% 20 Missing ⚠️
codelimit/common/gsm/utils.py 78.00% 11 Missing ⚠️
codelimit/common/gsm/automata/State.py 64.00% 9 Missing ⚠️
codelimit/common/ScanTotals.py 78.26% 5 Missing ⚠️
...elimit/common/token_matching/predicate/Balanced.py 87.50% 4 Missing ⚠️
codelimit/common/gsm/predicate/Predicate.py 76.92% 3 Missing ⚠️
codelimit/common/ScanResultTable.py 92.30% 2 Missing ⚠️
codelimit/common/gsm/matcher.py 97.82% 2 Missing ⚠️
codelimit/common/scope/scope_utils.py 97.05% 2 Missing ⚠️
... and 10 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   94.88%   94.40%   -0.48%     
==========================================
  Files          59       88      +29     
  Lines        1974     2736     +762     
==========================================
+ Hits         1873     2583     +710     
- Misses        101      153      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robvanderleek robvanderleek merged commit 96aba04 into main Apr 6, 2024
2 checks passed
@robvanderleek robvanderleek deleted the issue-31-Multi-language_support branch April 6, 2024 17:07
@chenrui333
Copy link
Contributor

@robvanderleek since there is a license change with this PR, maybe it should be moved to a separate PR or cut a new release for it? Thanks!

relates to Homebrew/homebrew-core#168759

@robvanderleek
Copy link
Collaborator Author

Hi @chenrui333

Yes, I was planning to make a new release for the license change.
I worked a lot on the code-analysis part the past weeks and decided the implementation deserves a more strict open-source license than ISC.

I wasn't aware my changes in main would trigger Homebrew builds (BTW I'm impressed by the active and kind support from Homebrew maintainers).

Is it enough if I make a new release? Also, if I'm missing some kind of best practice where my development activities in main should not immediately lead to Homebrew changes, let me know.

@robvanderleek
Copy link
Collaborator Author

Hi @chenrui333
FYI I've released version 0.9.0: https://pypi.org/project/codelimit/0.9.0/

@chenrui333
Copy link
Contributor

yeah, new release would be good, but I notice there is some license discrepancy issue in the README though. Besides GPL-3.0 is deprecated. I will drop a quick PR on this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants