base_classes feature not working

[spaeps]

The new "base_classes" feature does not work in latest release 1.0.2, obviously, since latest merged pull request "Allow adding inline notices, to use inside tables #10" was wrongly written against release 1.0.1 and not against mainline, overwriting the previous one "Ability to specify own base classes #9", thus deleting the entire feature implementation.

Please, revert #10 and rewrite the patch (or ask original submitter @miguelsalespereira) and push a new release.

Thank you

[rhukster]

Hmm.. usually Github does a good job of merging into develop, i'll try to fix this manually.

[rhukster]

Resolved and re-released.

[spaeps]

Resolved and re-released.

Sorry but this is not solved at all.

The patch applied is exactly the same as the reverted pull request.

The patch has to be rewritten to not cut the base_classes parts or it would always overwrite them.

The only parts that should be merged are from line 74 to line 110 and line 65 (see the links).

The first set is the one responsible for the inline type addition, but has to be patched more to include the base_classes detection or it would not work inline (but only in block type).

The second set removes the condition for the processed text starting with "!", thus is unrelated and probably not necessary.

IMHO, since this feature is still broken, I suggest to re-revert the re-applied patch and re-re-release an 1.0.4 with only the new custom base_classes addition, that was already applied in February but never released (the reason I was using git).

Then, when the inline patch would be ready and good, it would be re-re-applied and re-re-re-released as 1.0.5.

Thank you

[rhukster]

Ugg.. pain in the butt. Please recreate the PR and i'll apply. Cheers.