Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript newBroflake constructor should match the function signature of the native binary constructor #134

Open
noahlevenson opened this issue Mar 30, 2023 · 0 comments

Comments

@noahlevenson
Copy link
Contributor

We initially avoided this because it's a lot of boilerplate to pass JS objects which match BroflakeOptions, WebRTCOptions, and EgressOptions and validate their structure. There was no need to write all that back when we were happy to use nearly everything in the default structures.

Today, though, things are changing. As of March 30, 2023, we're forcibly overriding 10 fields across those 3 configuration structures. It's probably time to clean this up.

The big brained approach: add JavaScript constructors to create JS counterparts to NewDefaultBroflakeOptions, NewDefaultWebRTCOptions, and NewDefaultEgressOptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant