Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from Cloudfront functions to Response headers for security #129

Open
t-richard opened this issue Nov 2, 2021 · 3 comments · May be fixed by #406
Open

Move from Cloudfront functions to Response headers for security #129

t-richard opened this issue Nov 2, 2021 · 3 comments · May be fixed by #406
Labels
enhancement New feature or request

Comments

@t-richard
Copy link
Contributor

t-richard commented Nov 2, 2021 •
edited
Loading

AWS announced today support for Response headers with a built-in preset for adding security headers.

https://aws.amazon.com/fr/about-aws/whats-new/2021/11/amazon-cloudfront-supports-cors-security-custom-http-response-headers/

I think it could replace the response cloudfront function and save on the extra cost.

Unfortunatly, Cloudformation (and so CDK) support is not there yet, so I'm opening this to gather feedback and hopefully not forget about it 😅

There's also the option to add CORS headers on the distribution which may be useful for the server side website and even custom fixed value headers (no use case yet from my POV).

EDIT: more detailed article here https://aws.amazon.com/fr/blogs/networking-and-content-delivery/amazon-cloudfront-introduces-response-headers-policies/
@mnapoli mnapoli added the enhancement New feature or request label Nov 3, 2021
@mnapoli
Copy link
Member

mnapoli commented Nov 3, 2021

Wow that's super cool! I completely missed that. Let's revisit when CDK support is in!

@MarcErdmann
Copy link

@mnapoli Any update on this? Support seems to be available: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_cloudfront.ResponseSecurityHeadersBehavior.html

@mnapoli
Copy link
Member

mnapoli commented Jul 8, 2022

@MarcErdmann as you can see in this page, there was no comment saying this is implemented :)

So there is no update on this. Feel free to start working on it 👍

jackylamhk added a commit to jackylamhk/serverless-lift that referenced this issue Sep 7, 2024
@jackylamhk
fix: Use response headers instead
6e2f107 
Fixes getlift#129 getlift#350
@jackylamhk jackylamhk linked a pull request Sep 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove CloudFront functions jackylamhk/serverless-lift
3 participants
@mnapoli @MarcErdmann @t-richard