Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only do docker run when the image exists #17

Open
kienstra opened this issue Aug 28, 2021 · 1 comment
Open

Only do docker run when the image exists #17

kienstra opened this issue Aug 28, 2021 · 1 comment

Comments

@kienstra
Copy link
Member

The Final Terminal does docker run to get bash access to the committed image:

`docker run -it --rm ${committedContainerBase}${jobName}`

But if the CircleCI job passed or failed too soon, there might not be an image.

Then, there will be an error:

* Cannot find a job named `test_php74` to run in the `jobs:` section of your configuration file.

Instead, maybe there should be no Final Terminal, or it should open with a message that it couldn't debug the job.

@kienstra
Copy link
Member Author

This could probably use an if conditional around it to check that it has an image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant