Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Personalize support #3785

Closed
kmiller96 opened this issue Mar 19, 2021 · 6 comments · Fixed by #5398
Closed

Feature Request: Personalize support #3785

kmiller96 opened this issue Mar 19, 2021 · 6 comments · Fixed by #5398

Comments

@kmiller96
Copy link

Hi team - thank you so much for all your hard work on the Moto package. This thing is a god send!!

I've noticed that there is currently no way to mock Amazon Personalize. Is this something on your radar? Happy to implement the endpoint myself if I can be pointed in the right direction.

@bblommers
Copy link
Collaborator

Hi @kmiller96, happy to hear that Moto is useful for you!

I'm not aware of any plans to mock that service, so if you have the time, PR's are always welcome.
There's a write-up here on how to get started with a new service: https://github.com/spulec/moto/blob/master/CONTRIBUTING.md#missing-services

Let me know if you need any help.

@kmiller96
Copy link
Author

I've struggled with this for ages. I can't seem to build the lxml wheel on my VM regardless how hard I try. How do you resolve this install issue?

 src/lxml/etree.c:249681:62: error: ‘PyTypeObject {aka struct _typeobject}’ has no member named ‘tp_print’; did you mean ‘tp_dict’?
     __pyx_type_4lxml_5etree___pyx_scope_struct_14_iterentities.tp_print = 0;
                                                                ^~~~~~~~
                                                                tp_dict
  Compile failed: command '/usr/bin/gcc' failed with exit code 1
  creating tmp
  cc -I/home/ec2-user/miniconda3/envs/moto-dev/include/libxml2 -I/home/ec2-user/miniconda3/envs/moto-dev/include -I/usr/include/libxml2 -c /tmp/xmlXPathInitevt8chza.c -o tmp/xmlXPathInitevt8chza.o
  cc tmp/xmlXPathInitevt8chza.o -L/home/ec2-user/miniconda3/envs/moto-dev/lib -lxml2 -o a.out
  error: command '/usr/bin/gcc' failed with exit code 1
  ----------------------------------------
  ERROR: Failed building wheel for lxml

I've installed Cython, libxml2-dev, and libxslt-dev but I can't seem to figure it out from there. For the moment I've resorted to solving the dependencies manually during make test runs, but I couldn't get the make init target working for me.

Sorry if this is a dumb question - I'm quite new to contributing to open source. I'll keep pushing through as I really want this feature!

@kmiller96
Copy link
Author

I think I resolved the issue - the problem was that my virtual environment had python>=3.9. I reverted to python=3.8.8 and that resolved this issue for me. I figured that out by seeing a similar issue being discussed over here: seomoz/reppy#122

@bblommers
Copy link
Collaborator

Thanks for posting the fix, @kmiller96. Usually it is a matter of installing libxml2-dev and libxslt-dev, but I wasn't aware it was broken on Py3.9

@bblommers
Copy link
Collaborator

@kmiller96 Just figured out the root cause - we're pinning a version of lxml that does not have support for Py3.9.
A separate PR has been raised to fix this. Apologies for the troubles.

@kmiller96
Copy link
Author

No problem @bblommers. I managed to work around it, and the posted answer should have helped someone else who had the same issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants