responses_mock.remove() causes infinite loop

[ralphie0112358]

moto.core.responses_custom_registry.CustomRegistry does not implement remove() method, code will fallback to inherited responses.registries.FirstMatchRegistry

test env is current moto master (release 5.0.25) using make init

here is a test case which fails due to infinite loop

import moto
import requests
import responses
from unittest import TestCase


class TestBad(TestCase):

    @responses.activate
    @moto.mock_aws
    def test_bad(self):
        from moto.core.models import responses_mock

        responses_mock.get(url="https://example.com/", body="test")
        resp = requests.get("https://example.com/")
        assert resp.text == "test"

        # causes infinite loop
        responses_mock.remove("GET", "https://example.com/")


if __name__ == "__main__":
    import unittest
    unittest.main()

suggested fix

    def remove(self, response: responses.BaseResponse) -> list[responses.BaseResponse]:
        removed_responses = []
        registered = self._registered[response.method]
        while response in registered:
            registered.remove(response)
            removed_responses.append(response)
        return removed_responses

[ralphie0112358]

also, .replace is not implemented. suggested implementation

def replace(self, response: responses.BaseResponse) -> responses.BaseResponse:
    registered = self._registered[response.method]
    try:
        index = registered.index(response)
    except ValueError:
        raise ValueError(f"Response is not registered for URL {response.url}")
    registered[index] = response
    return response