Upgrade htmlparser2

[alxndrsn]

The current version behaves unhelpfully when Parser.write(undefined) is called:

code

h = e => (...args) => console.log(e, { args });
p = new (require('htmlparser2').Parser)({
  onend:h('onend'),
  onopentag:h('onopentag'),
  ontext:h('ontext'),
  onclosetag:h('onclosetag'),
});
p.write(undefined);
p.end();

with current dependency (3.9.2)

ontext { args: [ 'undefined' ] }
onend { args: [] }

with latest version (9.1.0)

Uncaught TypeError: Cannot read properties of undefined (reading 'length')
    at Tokenizer.shouldContinue (htmlparser2-undefined/node_modules/htmlparser2/lib/Tokenizer.js:608:41)
    at Tokenizer.parse (htmlparser2-undefined/node_modules/htmlparser2/lib/Tokenizer.js:616:21)
    at Tokenizer.write (htmlparser2-undefined/node_modules/htmlparser2/lib/Tokenizer.js:150:14)
    at Parser.write (htmlparser2-undefined/node_modules/htmlparser2/lib/Parser.js:460:28)

[matthew-white]

I'm not opposed to updating htmlparser2. But I'm also having trouble thinking of how it could get passed undefined. Is there somewhere in Backend where that happens?

[alxndrsn]

I'm not opposed to updating htmlparser2. But I'm also having trouble thinking of how it could get passed undefined. Is there somewhere in Backend where that happens?

I doubt it happens deliberately. It happened to me while modifying SQL generation for export streaming (unjoiner()?) and took a while to understand why things were failing and what exactly I'd broken.