Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make check-migrations should not be necessary #1397

Open
alxndrsn opened this issue Feb 11, 2025 · 1 comment · May be fixed by #1398
Open

make check-migrations should not be necessary #1397

alxndrsn opened this issue Feb 11, 2025 · 1 comment · May be fixed by #1398
Assignees
@alxndrsn

Comments

@alxndrsn
Copy link
Contributor

alxndrsn commented Feb 11, 2025 •
edited
Loading

Encountered while working on #1363, it looks like the check-migrations script should not be required.

check-migrations was introduced in dev by #461 and prod by getodk/central#276.

The script should not be necessary, as run-migrations should fail with non-zero exit code if the migrations have not all run.
@alxndrsn
Copy link
Contributor Author

May be removed from prod by getodk/central#891

alxndrsn pushed a commit to alxndrsn/odk-central-backend that referenced this issue Feb 11, 2025
Makefile: remove check-migrations
64780dd 
See: getodk#1397
alxndrsn pushed a commit to alxndrsn/odk-central-backend that referenced this issue Feb 11, 2025
Makefile: remove check-migrations
4920acf 
Closes: getodk#1397
@alxndrsn alxndrsn linked a pull request Feb 11, 2025 that will close this issue
Draft
2 tasks
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Feb 11, 2025
@alxndrsn alxndrsn moved this from 🕒 backlog to ✏️ in progress in ODK Central Feb 11, 2025
@alxndrsn alxndrsn self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxndrsn alxndrsn

Labels
None yet
Projects
ODK Central
Status: ✏️ in progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove check-migrations alxndrsn/odk-central-backend
1 participant
@alxndrsn