Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or refactor FormGroup #400

Open
matthew-white opened this issue Dec 17, 2020 · 0 comments
Open

Remove or refactor FormGroup #400

matthew-white opened this issue Dec 17, 2020 · 0 comments
Labels
refactor Improves code without altering behavior

Comments

@matthew-white
Copy link
Member

Our FormGroup component corresponds to the Bootstrap form-group class. It is used when a .form-group has a corresponding .form-label. The component also implements functionality around the form control.

FormGroup worked well when we only used simple input elements for the form control. However, we now use .form-group and .form-label together with select elements, as well as the flatpickr input. That means that there are a few situations in which .form-group must be used, but FormGroup cannot be, which seems potentially confusing.

We could consider refactoring FormGroup so that it works with a variety of form controls. However, FormGroup does relatively little work outside of the form control, so it may also make sense to remove the component and go back to just using .form-group outside a component.

@matthew-white matthew-white added the refactor Improves code without altering behavior label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves code without altering behavior
Projects
None yet
Development

No branches or pull requests

1 participant