Added link to entity and dataset from submission activity feed #790
Conversation
ktuite
force-pushed
the
ktuite/submission-feed-entity-link
branch
from
a656ffd to
ffa7e65
Compare
| "create": "Created Entity {label} in {dataset} Dataset", | ||
| "create": "Created Entity {label} in Dataset {dataset}", |
There was a problem hiding this comment.
Do we definitely want to make this change? I know it's "Dataset {dataset}" in the current release criteria, but I'm not sure that's intentional. I think we landed on "{dataset} Dataset" during 2022.3 after considering both options: https://docs.google.com/document/d/1naxyzFU8EjcWKfYzE_mEF5cY38l1QRNUZ_0VW2Gp-r0/edit?disco=AAAAZ-n7VuE
There was a problem hiding this comment.
We don't definitely want to make it, so i'll put it back.
Just saw it in the release criteria and felt drawn to it... We have more formatting than we did before and it's also weird how Entity X and Y Dataset are not following the same pattern.
There was a problem hiding this comment.
I see what you mean about the inconsistency. I think it works this way only because {dataset} is a single word, so "{dataset} Dataset" becomes almost like a compound noun.
Closes #773. Adds links from an entity create event in the submission feed directly to the entity and dataset. Also adds a
entityPathroute inuseRoutes.What has been done to verify that this works as intended?
Tests, trying it in action.
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes