Allow editing a finalized form

[seadowg]

Figma link

Acceptance

• Given I've filled out and finalized (or sent) a form
  When I open that submission to view it from "Ready to send" (or "Sent")
  And I click on the ✏️ icon in the app bar
  Then the submission is opened for editing with the same answers

• Given I've filled out and finalized a form
  When I open that submission to view it from "Ready to send"
  And I click on the ✏️ icon in the app bar
  And I make changes and finalize
  Then both the original and edited submission are visible in Ready to send

• Given I've filled out and sent a form
  When I open that submission to view it from "Sent"
  And I click on the ✏️ icon in the app bar
  And I make changes and send it
  Then that edited submission shows up as an edit in Central

Notes

Edited submissions should use include the deprecatedId metadata element linking them back to the submission they are an edit of. This is already how edits work in Central.

Questions

• Is using deprecatedId enough to have edits show correctly in Central?
  • Yes!

[grzesiek2010]

@seadowg should the deprecatedId be present in blank forms like instanceId, so it’s automatically added to saved forms (if populated), or should we add it dynamically when editing starts? As I understand, it’s the latter, correct?

[seadowg]

@seadowg should the deprecatedId be present in blank forms like instanceId, so it’s automatically added to saved forms (if populated), or should we add it dynamically when editing starts? As I understand, it’s the latter, correct?

Yup: deprecatedId isn't included in the blank form XML, and we need to add it to the instance XML when saving.