sentrySvelteKit in vite.config.ts does not upload sourcemaps

[ktarmyshov]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/sveltekit

SDK Version

8.52.0

Framework Version

SvelteKit 2.16.1

Link to Sentry event

No response

Reproduction Example/SDK Setup

vite.config.ts

  plugins: [
    sentrySvelteKit({
      adapter: 'auto',
      sourceMapsUploadOptions: {
        org: <org removed>,
        project: <project removed>,
        authToken: SENTRY_AUTH_TOKEN,
      }
    }),
    sveltekit(),
    purgeCss(),
    // Put the Sentry vite plugin after all other plugins
    // sentryVitePlugin({
    //   org: <org removed>,
    //   project: <project removed>,
    //   authToken: process.env.SENTRY_AUTH_TOKEN,
    // }),

Steps to Reproduce

added (see above) modifications to vite config.
If I use sentryVitePlugin - some uploading is happening at the end of build but BEFORE the adapter is executed
sentrySvelteKit has no effect and does nothing.

Expected Result

sentrySvelteKit plugin should upload sourcemaps.

Actual Result

Nothing seems to be uploaded

[Lms24]

Hey @ktarmyshov thanks for writing in! Some things to narrow this down:

• You use adapter-auto, correct? where do you deploy your app to? Is your build command the default vite build command?
• You don't need to add @sentry/vite-plugin (the one in the comment). It doesn't work by default in SvelteKit due to kit executing the adapter at the very end. sentrySvelteKit should take care of this.

[ktarmyshov]

@Lms24 Hi, Lukas!

I do use different adapters for different env variables, but when I build for preview, I use adapter-auto - yes. Build command "vite build --mode development"

I tried vite-plugin, to see if there is a difference, and vite-plugin does upload the sourcemaps - I see various log messages, debug id, etc.
But sentrySvelteKit does nothing.

[Lms24]

Thanks for getting back to me! I tried to reproduce this with adapter-auto but for me source maps were uploaded correctly. See my reproduction repository: https://github.com/Lms24/gh-sentry-javascript-15227-sveltekit-no-sourcemaps

Would you mind pointing out what I need to add in my reproduction so that the bug appears? Otherwise please provide your own reproduction. I can't really see it but any chance that the purgeCss plugin is interfering somehow?

[ktarmyshov]

Hi, Lukas!
is it supposed to print anything into the STD? I ran npm i, npm run build, see no output, if it's uploading or not finding project, auth token, etc.

[ktarmyshov]

Is it possible to enable output debug/trace for the plugin, what it's doing?

[ktarmyshov]

I got your repo working for me as well, but for my repo it's not working :(

[ktarmyshov]

found:
if (svelteKitPluginOptions.autoUploadSourceMaps && process.env.NODE_ENV !== 'development') {
that's why

[Lms24]

If you set sentrySvelteKit({debug: true}), you should get debug output.

[Lms24]

found:
if (svelteKitPluginOptions.autoUploadSourceMaps && process.env.NODE_ENV !== 'development') {
that's why

hmm yes this is a safeguard not to upload when the dev server is running. I'm wondering why the NODE_ENV would be set to development in a prod build though. Usually Vite sets this by itself 🤔

[ktarmyshov]

I was setting NODE_ENV to development also for build, that's why it wasn't working. So I will close the issue, need to figure out, when to set it and when not to set it :), or do I need to set it at all.

[Lms24]

Oh interesting, I see! If you have a good reason to set NODE_ENV manually, let me know because we rely on it in quite a few places (also in other SDKs and our bundler plugins) and I'm curious about the use case :)

Closing as completed for now.

[ktarmyshov]

Since sentry print logs when uploading maps, it could be useful to print why it won't upload in case it won't

[Lms24]

yeah I agree, let me think about this and the env variable check at this point. it doesn't seem completely sound to me.