-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering errors from host-environment SDKs #15321
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-ingestion-and-filtering for triage ⏲️ |
Hi, we strongly discourage people from running global Sentry instances in "embeddables" (extensions, iframes, SDKs) and recommend following this guide for using the SDK in an isolated way so that global errors don't leak between instances: https://docs.sentry.io/platforms/javascript/best-practices/multiple-sentry-instances/ The street goes both ways if you don't adhere to this guide. If your users install a global Sentry instance (which they are encouraged to do), their data will leak into your instance, and in reverse, your data will leak into their instance. |
I just realized that your website is being often accessed from in-app browsers. For that case I need to think some more. |
Two things:
|
Yeah this is super cool and we're discussing it internally - we also use GTM which does load some third party code on our site and would be filtered out, but maybe we're okay with that. Definitely exploring it.
Do you want links to the sentry issues, or copy-pastes of out of the error messages?
Is the one we get from fillr constantly, which we're now ignoring via the client side ignore feature. We think these two are also fillr, but are less confident:
|
@Dav1dde do you think we could @bagedevimo are you using fillr yourself? |
@lforst yes, don't even have to add it to Relay. We can do it like Chunkload and Hydration errors in Sentry: https://github.com/getsentry/sentry/blob/6c8211bf06f2c4054369cafbb45dfd3feb001fd5/src/sentry/ingest/inbound_filters.py#L339-L373 |
wouldn't it be faster (computing-wise) or whatever in Relay? |
These rules are passed down to Relay, Relay evaluates them, but you can define them in Sentry. |
Nope |
We're still investigating this, thanks for all the extra info. |
Problem Statement
Our site frequently gets embedded into other peoples apps (Facebook, TikTok, Afterpay, Klarna, etc) via them doing their own "in-app browser" type thing. This means our code is running in whatever javascript environment they have set, and we have little control of some of the code that gets injected into the page, same as a browser extension does.
Unlike a browser extension, these aren't filtered out by Sentry's wonderful issue filters and just fill our javascript issue tracking with unsolvable noise.
For example:
These are almost certainly coming from https://www.fillr.com/ which is embedded into the Afterpay mobile app, per the user agent:
Mozilla/5.0 (Linux; Android 14; SM-S918B Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/132.0.6834.122 Mobile Safari/537.36 AfterpayMobile/5520
Solution Brainstorm
Similar to "filter issues from known extensions", add a "filter issues from known embedders" feature which uses that magic ( i assume you look for extension IDs in backtraces? ) but does some other magic for this use case instead. Not really idea what that magic would be sorry, real PITA.
Product Area
Ingestion and Filtering
The text was updated successfully, but these errors were encountered: