Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract span attrs from AIOHTTP request #3782

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Nov 15, 2024

  • can't use objects in sampling_context anymore, so get rid of aiohttp_request
  • pick out meaningful properties from the AIOHTTP request and set them as span attributes (following OTel's semconv)

Part of #3746

Copy link

codecov bot commented Nov 15, 2024

❌ 1710 Tests Failed:

Tests completed Failed Passed Skipped
19997 1710 18287 4413
View the top 1 failed tests by shortest run time
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-00:00-expected_output4]
Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
View the full list of 2 ❄️ flaky tests
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-0000-expected_output6]

Flake rate in main: 57.14% (Passed 39 times, Failed 52 times)

Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.16% (Passed 2 times, Failed 235 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sentrivana sentrivana mentioned this pull request Nov 15, 2024
12 tasks
@sentrivana sentrivana marked this pull request as ready for review November 15, 2024 11:46
@sentrivana sentrivana merged commit 1dc4c28 into potel-base Nov 15, 2024
43 of 121 checks passed
@sentrivana sentrivana deleted the ivana/custom-sampling-context-aiohttp branch November 15, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants