chore(auth): remove max scope for partners

[sentaur-athena]

I added this piece of code a couple of weeks ago because we wanted to limit partners max scope but we decided not to. Removing it because it adds extra complexity

[GabeVillalobos]

looks good to me, but I also don't fully understand the implications of removing this so I'll defer to you + security on it.

[sentaur-athena]

@GabeVillalobos it's a product decision we made initially but then in practice it ended up being too daunting for a partner. The scopes no matter what partner requests for will be visible to the user and user can decide if that's too much scope and they don't want to grant.

[mdtro]

@sentaur-athena Is it necessary to remove this? For partners that need the max scopes, wouldn't we just check all the scopes? That way, with cases where the scope does need a subset of the max it can be restricted still.

[sentaur-athena]

@mdtro I'm open to keeping it but it creates complexity that we don't have a reason for right now.

I realized we keep defining new scopes, like alerts scopes are create just a couple of weeks ago and member:invite scope. Having this logic will enforce us to backfill every time a new scope gets created.

Other solution would be to keep the max scope but if it's empty we assume it's all. 😅

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
23356	1	23355	213

View the top 1 failed tests by shortest run time

tests.sentry.sentry_metrics.test_snuba.SnubaMetricsInterfaceTest::test_count_query

Stack Traces | 3.4s run time

#x1B[1m#x1B[.../sentry/sentry_metrics/test_snuba.py#x1B[0m:57: in test_count_query
    data = get_series(
#x1B[1m#x1B[.../snuba/metrics/datasource.py#x1B[0m:1071: in get_series
    ).get_snuba_queries()
#x1B[1m#x1B[.../snuba/metrics/query_builder.py#x1B[0m:1133: in get_snuba_queries
    component_entities = metric_field_obj.get_entity(
#x1B[1m#x1B[.../metrics/fields/base.py#x1B[0m:784: in get_entity
    return _get_entity_of_metric_mri(projects, self.metric_object.metric_mri, use_case_id).value
#x1B[1m#x1B[.../metrics/fields/base.py#x1B[0m:278: in _get_entity_of_metric_mri
    raise InvalidParams(f"Raw metric {get_public_name_from_mri(metric_mri)} does not exist")
#x1B[1m#x1B[31mE   sentry.exceptions.InvalidParams: Raw metric measurements.speed does not exist#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[sentaur-athena]

I realized letting partners to have max scope (even the future ones created) is more code change that I want to make today before holidays. Will close this for now but that's the route I will go when back from holidays.