feat: Add a flag to wait for delivery callback in taskworker #83167
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it is helpful to have the taskworker actually wait for the kafka producer to acknowledge that the sent task has been successfully added to Kafka. In particular this is useful for testing scenarios. Add a flag to the task definition that can determine whether the worker should wait for the produce to be acknowledged before continuing.
github-actions
bot
added
the
Scope: Backend
john-z-yang
reviewed
Jan 9, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83167 +/- ##
==========================================
- Coverage 87.59% 87.58% -0.01%
==========================================
Files 9459 9461 +2
Lines 536667 536917 +250
Branches 21116 21116
==========================================
+ Hits 470088 470274 +186
- Misses 66220 66284 +64
Partials 359 359 |
markstory
reviewed
Jan 9, 2025
|
|
||
| activation = simple_task.create_activation() | ||
|
|
||
| with patch.object(namespace, "producer") as mock_producer: |
There was a problem hiding this comment.
Wouldn't the mock need to return a Future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is helpful to have the taskworker actually wait for the kafka producer to acknowledge
that the sent task has been successfully added to Kafka. In particular this is useful for testing
scenarios. Add a flag to the task definition that can determine whether the worker should wait for
the produce to be acknowledged before continuing.