Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all features in the SDKs when spotlight:true #247

Open
4 tasks
HazAT opened this issue Dec 7, 2023 · 2 comments
Open
4 tasks

Enable all features in the SDKs when spotlight:true #247

HazAT opened this issue Dec 7, 2023 · 2 comments
Assignees
Labels
Type: Enhancement New feature or request

Comments

@HazAT
Copy link
Member

HazAT commented Dec 7, 2023

When someone sets spotlight:true in a Sentry SDK - we should up all sample rates.

Tasks

@dcramer
Copy link
Member

dcramer commented Dec 7, 2023

IMO the better approach here would be to move this logic (and define the spec around it) until the envelope crafting bits. This is still not ideal all the time because you're wasting CPU in prod when something might not sample/etc. I dont think we should compromise there, but it also smells funny to magically change the config.

It could just be something like if spotlight or should_sample: do the thing() and put those checks everywhere.

@Shubhdeep12 Shubhdeep12 added the Type: Enhancement New feature or request label Feb 3, 2024
@BYK
Copy link
Member

BYK commented Nov 4, 2024

Related #543

@BYK BYK self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants