Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Profiles #565

Open
BYK opened this issue Nov 19, 2024 · 1 comment
Open

Add support for Profiles #565

BYK opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
Type: Enhancement New feature or request

Comments

@BYK
Copy link
Member

BYK commented Nov 19, 2024

We have rich profile data and it would be great to enrich the tracing view with this data since we get it from most of the popular SDKs now.

I want to do 2 things with profiles:

Resources:

@BYK
Copy link
Member Author

BYK commented Jan 28, 2025

Some progress on this:

Image

Things to improve:

  • We need a way to group/collapse deep spans with just a single child or repeated spans
  • We need a way to find at which depth to start showing the "augmented" profile information when we are filling in the gaps for the existing tracing instrumentation. The challenge here is, the span information we collect has no information regarding the dept of the callstack or any stack-related information at all. They mostly correspond to wrapped function calls though so we should be able to run some heuristics there
  • Performance itself needs to be worked on. Right now I do all the calculations on the fly at display time. We can (and should) pre-load most of this work at profile ingestion if not all of that.
  • We need a toggle for "only show in-app stack frames"

Aside, we can now surface "the most time consuming function calls" under insights with a different processing of the profile data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant