Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename inflight_taskactivations.deadletter_at #117

Open
markstory opened this issue Jan 15, 2025 · 0 comments · May be fixed by #130
Open

Rename inflight_taskactivations.deadletter_at #117

markstory opened this issue Jan 15, 2025 · 0 comments · May be fixed by #130
Assignees
@markstory

Comments

@markstory
Copy link
Member

markstory commented Jan 15, 2025 •
edited
Loading

The column deadletter_at isn't only used for deadlettering. It is used as a deadline after which tasks are removed from inflight tasks. During our meeting today names like:

  • purge_at
  • remove_at

We should replace the column and update surrounding logic.
@markstory markstory self-assigned this Jan 17, 2025
markstory added a commit that referenced this issue Jan 17, 2025
@markstory
Rename deadletter_at -> remove_at
b0633c1 
The name deadletter_at was a bit misleading as activations past this
deadline were not always deadlettered. Based on an activation's retry
policy they could be discarded as well.

Refs #117
@markstory markstory linked a pull request Jan 17, 2025 that will close this issue
Open
@markstory markstory linked a pull request Jan 17, 2025 that will close this issue
Rename deadletter_at -> remove_at #130
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markstory markstory

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename deadletter_at -> remove_at getsentry/taskbroker
1 participant
@markstory