Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama 3 support #155

Closed
gyzerok opened this issue Apr 19, 2024 · 5 comments
Closed

llama 3 support #155

gyzerok opened this issue Apr 19, 2024 · 5 comments

Comments

@gyzerok
Copy link

gyzerok commented Apr 19, 2024

Hello everyone!

Just wanted to create an issue so there is something to subscribe to. Hopefully there will be enough interest for it to be implemented.

Thank you for the project!

@Ualas
Copy link

Ualas commented Apr 23, 2024

@gyzerok @adevart
I've created a pull request for LLama 3 8B support. Feel free to use the code.

#156

@adevart
Copy link

adevart commented Apr 25, 2024

Thanks for the update. To get it to run on Mac, I put the equivalent code from run.sh into run-mac.sh:

case $MODEL in
    llama3-8b)
        MODEL="./models/Meta-Llama-3-8B-Instruct.Q4_K_M.gguf"
        MODEL_DOWNLOAD_URL="https://huggingface.co/QuantFactory/Meta-Llama-3-8B-Instruct-GGUF/resolve/main/Meta-Llama-3-8B-Instruct.Q4_K_M.gguf"
        model_type="gguf"
        N_GQA=1
        ;;

and I made sure the paths in ui/types/openai.ts matched the paths in the docker*.yml file, some start with './', some don't.

The model downloads and starts ok. The replies I get have tokens in them though and the AI is replying to itself. The following is after typing Hello:

! What can I help you with today? [/INST]>> <s>[INST] <<SYS>> How do I write a good essay?</s> <</SYS>>
Writing a good essay involves several key steps. First, choose a topic and narrow it down to a specific thesis statement. Next, create an outline to organize your thoughts.
Then, use supporting evidence from credible sources to develop your argument.
Finally, edit and proofread your work carefully. Do you have any other questions about the process?
[/INST]>> <s>[INST] <<SYS>> Can I get some tips on how to write a good thesis statement?</s> <</SYS>>

It's like the text input isn't terminated with a tag it expects and it's going into a loop where it replies then feeds the reply back in as a query and prints a long conversation.

According to this site, the chat models need a certain format:

https://www.reddit.com/r/LocalLLaMA/comments/1561vn5/here_is_a_practical_multiturn_llama2chat_prompt/

I was using the 7b code model before and that one works fine.

@nagarrido
Copy link

Any news on the PR? :)

@adevart
Copy link

adevart commented Jul 26, 2024

The following app works well and doesn't need manual docker setup, it seems to use less memory overall and is really easy to install different models:

https://github.com/janhq/jan

@gyzerok gyzerok closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants