This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Several cleanups #117
Closed
Several cleanups #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
services/bash isn't used anyway AFAIK. I already cleaned up a lot of this https://github.com/runcitadel/manager and could completely drop that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116
I went through the codebase and saw a few issues which I suspect are things that have crepped in over time.
To summarise:
I noticed within docker-compose.yaml (umbrel repo) that the Docker unix socket and binary get mounted in however they are not used at all: https://github.com/getumbrel/umbrel/blob/master/docker-compose.yml#L95
I would suggest we remove that from the yaml because if the manager gets compromised then every single container can get compromised.