Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package app #8

Draft
wants to merge 54 commits into
base: dev
Choose a base branch
from
Draft

Package app #8

wants to merge 54 commits into from

Conversation

vsriram24
Copy link
Collaborator

Package the app so that a user can call library(oncarto) and then oncarto::runApp() to have the Shiny app appear. Also includes some debugging of user inputs to ensure that the correct results are being presented.

@vsriram24 vsriram24 added the enhancement New feature or request label Sep 20, 2024
@vsriram24 vsriram24 requested a review from seankross September 20, 2024 21:21
@vsriram24 vsriram24 linked an issue Sep 20, 2024 that may be closed by this pull request
Package the Shiny app #6
Open
@vsriram24 vsriram24 changed the base branch from main to dev September 20, 2024 21:22
@seankross seankross marked this pull request as draft September 23, 2024 20:18
@seankross
Copy link
Contributor

Let's put this PR on hold until we chat about #3 and #5.

@vsriram24 vsriram24 changed the base branch from dev to hutch-theme September 23, 2024 20:58
@vsriram24 vsriram24 changed the base branch from hutch-theme to dev November 14, 2024 18:32
vsriram24 and others added 17 commits November 14, 2024 11:39
@vsriram24
Resolve merge conflicts btwn dev and package-app
96955bb
@vsriram24
Drop renv
39bfcd5
@vsriram24
Beginning to functionalize UI 11/18
ea52032
@vsriram24
Resolve basic app running issues
842a1ca
@vsriram24
Add remaining selectInputs for incidence UI
bf6d703
@vsriram24
Add UI for incidence output
a642859
@vsriram24
Add UI for contact info in incidence
252aad9
@seankross
moving files around to make your life easier
ad3a09e
@vsriram24
Add UI for background tab
c24bee2
@vsriram24
Merge pull request #15 from getwilds/package-app-sk
34ee49f 
moving files around to make your life easier
@vsriram24
Correct info for background UI
d81977d
@vsriram24
Include NS for UI
8a5b324
@vsriram24
Server logic for background tab + background data
61b4aa6
@vsriram24
Update server logic for contact info in incidence tab
3f87fea
@vsriram24
Ingest data for incidence on server
ca37500
@vsriram24
Fix ref to get_data fn
f14228e
@vsriram24
Filter input data and functionalize contact info
6c6e812
vsriram24 and others added 30 commits November 25, 2024 12:53
@vsriram24
Merge pull request #16 from getwilds/nov-22-coworking
a65ce91 
all of the co working stuff we talked about
@vsriram24
Move logic for contact info from server to UI
5cc39fc
@vsriram24
drop extraneous server logic for bground
52b6b47
@vsriram24
Add param statements for data_table_name and state_abbr in run-app
f80e01f
@vsriram24
Get choropleth map and message working without functionalization
739d490
@vsriram24
Functionalize palette
cc113f5
@vsriram24
Functionalize making leaflet map
5800d0f
@vsriram24
Clean up parameter calls between run-app and server
90481b7
@vsriram24
Fix filename for make-leaflet
89edd5f
@vsriram24
Remove extraneous scripts and clean up make-leaflet
2c43264
@vsriram24
Resolve NOTES from running check()
1ea6318
@vsriram24
Include packages for function calls
8f927d1
@vsriram24
Package addt for NAMESPACE
3d4a330
@vsriram24
Include more package defs for fns
c7f8a5e
@vsriram24
Resolve addPolygons issue in leaflet
1bbf2e3
@vsriram24
Clean up server-county-incidence
9139294
@seankross
fixed logo and added testing
2ef4a6a
@vsriram24
Merge pull request #17 from getwilds/package-app-logo-fix-and-testing
257f05e 
fixed logo and added testing
@vsriram24
Plan out tests and create sample data
cd8fcc8
@vsriram24
Further test dev and addResourcePath pkg
059a2ef
@vsriram24
Change map_message to NULL for easier testing
dcedc49
@vsriram24
Baseline test format with sample data
fdca1b3
@vsriram24
Failed test. Trying to debug
705e012
@vsriram24
Turn get_data into a callback
73b6aeb
@vsriram24
Disentangle incidence outputs
94241f4
@vsriram24
Working tests (half of them)
8c3f9db
@vsriram24
We're not gonna bother about shinytest2
5a61a45
@vsriram24
Reorg inst/ folder
4f4d5c0
@vsriram24
Introduce contact_info md as an argument for ui-county-incidence
480c25b
@vsriram24
Cleanup and check
d2435a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankross seankross Awaiting requested review from seankross

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package the Shiny app
2 participants
@vsriram24 @seankross