Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle ties or simultaneous loss properly. #13

Open
antdude opened this issue Oct 15, 2015 · 4 comments
Open

Does not handle ties or simultaneous loss properly. #13

antdude opened this issue Oct 15, 2015 · 4 comments

Comments

@antdude
Copy link

antdude commented Oct 15, 2015

-Bender(~Bender@0::1)- 1.) Obamacare +5 2.) Roundhouse Kick -4 3.) Holy Hand Grenade -1
                       4.) Grab 5.) Kroddychop -3
01:34PM Bender> FSY: 2
01:34PM Bender> It's Ant's turn.
01:34PM FSY> p 4
01:34PM Bender> The Tax Man appears on FSY's doorstep, personally delivers a Tax
          Return!
[01:34pm] Ant> C
-Bender(~Bender@0::1)- 1.) Obamacare +5 2.) Roundhouse Kick -4 3.) Holy Hand Grenade -1
                       4.) Grab 5.) Kroddychop -3
[01:34pm] Ant> T
01:34PM Bender> It's Ant's turn. Roster -- Ant: 1 - FSY: 2
01:34PM FSY> c
[01:34pm] Ant> P 4 5
01:34PM Bender> Ant grips FSY. Respond or pass, FSY.
01:34PM FSY> p 1
01:34PM Bender> FSY hides behind Your Mom! Her warts will provide much comfort. ;)
01:34PM Bender> WHAM! In a splendid display of martial arts, Ant thwaps FSY in the
          kidneys REALLY REALLY hard!
01:34PM Bender> FSY: 1
01:34PM Bender> It's FSY's turn.
[01:34pm] Ant> C
[01:34pm] Ant> T
-Bender(~Bender@0::1)- 1.) Obamacare +5 2.) Roundhouse Kick -4 3.) Holy Hand Grenade -1
01:34PM Bender> It's FSY's turn. Roster -- FSY: 1 - Ant: 1
[01:34pm] Ant> P 3
01:34PM Bender> Ant lobs The Holy Hand Grenade Of Antioch! The Grenade soars through
          the air, accompanied by a short bit of choral music, then bounces once and
          explodes. Everybody takes damage!
01:34PM Bender> Ant has foregone the finer things in life, like winning.
01:34PM Bender> FSY wins after 1 day, 11 minutes and 5 seconds, using 28 turns!
          Endurance bonus: +14. Glutton bonus: +9. Damage done: 46
01:34PM Bender> FSY: 0
01:34PM Bender> FSY was discharged from mortality.
01:34PM FSY> p 6
[01:34pm] Ant> HAHAHA
01:34PM Mousey> AWESOME
[01:34pm] Ant> :D
01:34PM FSY> lol
01:34PM Mousey> total bug
01:35PM Mousey> bigwin!
01:35PM Mousey> bugwin! even
01:35PM FSY> intereseting how it has me win after that
01:35PM Mousey> total bugwin
01:35PM Mousey> a comes before f, is my guess
[01:36pm] Ant> I think Lite said that is by design.
[01:36pm] Ant> Let me ask him again.

Didn't you say this is not a bug?

@kfprimm kfprimm added the bug label Oct 22, 2015
@kfprimm kfprimm changed the title Both players has 1 HP left and then I lobbed "Holy Hand Grenade -1" for both to die, but my opponent wins. Does not handle ties or simultaneous loss properly. Oct 22, 2015
@kfprimm
Copy link
Contributor

kfprimm commented Oct 22, 2015

@jaythomas must be tied up with work...

I believe that is the case as there is no provisioning for a tie. Certainly should be fixed.

@jaythomas
Copy link
Member

Fireball (Holy Hand Grenade) decrements players' health in the order of turn. So last player to be hit should be the last standing in such a situation:

+Lite .help brawl fireball
@Dark Fireball (-1 health) - 1 damage to everyone, starting with yourself.

Per rules of every card, there is an order that damage is done. Players are never actually hit simultaneous. House rules might say otherwise, but as @kfprimm points out ties were never considered nor provisioned for in the game's logic.

@antdude
Copy link
Author

antdude commented Oct 22, 2015

Lite/Jay: So none of the cards can have ties?

@jaythomas jaythomas added enhancement and removed bug labels Oct 22, 2015
@jaythomas
Copy link
Member

Correct.

I know it goes against the user's initial thought on how certain cards should work. You would think the card would continue to play out after you are killed. Certainly a grenade doesn't stop exploding just because you blew yourself up first. If future development continues on the junkyard code rewrite, modifying this behavior will be available as an option under "house rules".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants