Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action sync does not respect pagesize #41

Closed
ecg0030 opened this issue Aug 3, 2022 · 1 comment
Closed

Action sync does not respect pagesize #41

ecg0030 opened this issue Aug 3, 2022 · 1 comment

Comments

@ecg0030
Copy link

ecg0030 commented Aug 3, 2022

I'm using this config:

tables:
- source: table_name
  action: sync
  partition: hour
  pagesize: 50

However, I see this request being issued with a 10k limit:

20:09:43 WARN JsonRequest [main] table_name RESPONSE: GET https://<servicnow-url>/api/now/table/<table_name>?sysp
arm_limit=10000&sysparm_exclude_reference_link=true&sysparm_display_value=false&sysparm_fields=sys_id%2Csys_created_on%2Csys_updated
_on&sysparm_query=.....

I see in Synchronizer.java that this might be hardcoded and not respecting the pagesize option:

sntsr.setPageSize(10000);

I did not see this same issue when using since: last

@ecg0030
Copy link
Author

ecg0030 commented Aug 3, 2022

This appears to be resolved with the following pull request #42

@gflewis gflewis closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants