Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle links and newlines in sponsor description #40

Open
dbrgn opened this issue Aug 6, 2018 · 2 comments
Open

Handle links and newlines in sponsor description #40

dbrgn opened this issue Aug 6, 2018 · 2 comments
Assignees
@rnestler
Labels
enhancement

Comments

@dbrgn
Copy link
Contributor

dbrgn commented Aug 6, 2018

They should both be converted to HTML.
@rnestler
Copy link
Contributor

They should both be converted to HTML.

Or should the API server just deliver valid HTML?

@dbrgn
Copy link
Contributor Author

dbrgn commented Aug 10, 2018

That would be the other option :) I'd be a bit wary of that though, we would probably still have to sanitize the code. Therefore we gain little by putting markup in our server data.

On the other hand we could use markdown. But then again, converting just links and newlines would be easier.

@rnestler rnestler self-assigned this Aug 28, 2018
@dbrgn dbrgn mentioned this issue Apr 30, 2019
Merged
dbrgn added a commit that referenced this issue Apr 30, 2019
@dbrgn
Merge pull request #49 from gfroerli/40-sponsor-newlines
bba2034 
Split sponsor description at newlines.

Refs #40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnestler rnestler

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbrgn @rnestler