Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue::write_buffer_with() needs a more appropriate name #7006

Open
kpreid opened this issue Jan 27, 2025 · 0 comments
Open

Queue::write_buffer_with() needs a more appropriate name #7006

kpreid opened this issue Jan 27, 2025 · 0 comments
Labels
area: api Issues related to API surface

Comments

@kpreid
Copy link
Contributor

kpreid commented Jan 27, 2025

When originally envisioned, write_buffer_with() took a closure. It no longer does, and so the “with” part of the name no longer means anything. “With what?” It should be given a more meaningful name.

I don't have any really good ideas for what it should be called, though.

If it weren’t for the WebGPU specification defining writeBuffer(), and the churn, we could imagine renaming write_buffer_with() to write_buffer(), and rename the current write_buffer() (that copies from a provided slice) to copy_to_buffer().

write_buffer_mapping()?

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request area: api Issues related to API surface and removed type: enhancement New feature or request labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Issues related to API surface
Projects
None yet
Development

No branches or pull requests

2 participants