Correct usage of old code with slight LUT miscalculation #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing an article about the usage of LUTs in video games, I stumbled upon this QA article. Shown is a piece of code on how to emulate 3D Texture reads in WebGL 1.0, when no such function is present.
The code shown was outdated however, with a miscalculation on how the texture coordinates are accessed, leading to colors being blue-shifted. This was corrected by the original author of the code sample, @greggman in 2019, but the webglfundamentals article picked up the older version.
This PR corrects the code by replacing it with the newer version, which works flawlessly.