feat: add GGML_PAD_REFLECT_1D operation
#1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_pad_reflect_1d
ggerganov
approved these changes
Dec 3, 2024
ggerganov
reviewed
Dec 3, 2024
There was a problem hiding this comment.
We should refactor these type of test programs into a single test that has reference results for the operators (such as conv, conv_transpose, pad_reflect, etc.) and verifies all of them in a single run using just the CPU backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CPU and Metal kernels of the
PAD_REFLECT_1Doperation. A description of the operation can be found here.It is yet another operation that needs to be supported for Encodec.cpp to work.