-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. bug: since 235f6e1 llama-server's main.js overwrites Authorization header so Web UI fails behind authenticating reverse proxy #10854
Labels
Comments
Here's a patch which I believe solves the issue.
(And |
vesath
added a commit
to vesath/llama.cpp
that referenced
this issue
Dec 17, 2024
If no API key is set, leave the Authorization header as is. It may be used by another part of the Web stack, such as an authenticating proxy. Fixes ggerganov#10854
vesath
added a commit
to vesath/llama.cpp
that referenced
this issue
Dec 17, 2024
If no API key is set, leave the Authorization header as is. It may be used by another part of the Web stack, such as an authenticating proxy. Fixes ggerganov#10854
vesath
added a commit
to vesath/llama.cpp
that referenced
this issue
Dec 18, 2024
If no API key is set, leave the Authorization header as is. It may be used by another part of the Web stack, such as an authenticating proxy. Fixes ggerganov#10854
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this issue
Dec 20, 2024
* server: avoid overwriting Authorization header If no API key is set, leave the Authorization header as is. It may be used by another part of the Web stack, such as an authenticating proxy. Fixes ggerganov#10854 * rebuild --------- Co-authored-by: Xuan Son Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Name and Version
$ ./llama.cpp/build/bin/llama-cli --version
version: 4336 (08ea539)
built with cc (GCC) 14.2.1 20240910 for x86_64-pc-linux-gnu
Operating systems
Linux
Which llama.cpp modules do you know to be affected?
llama-server
Problem description & steps to reproduce
I am running llama-server behind Caddy as an authenticating reverse proxy. Once authenticated, all requests should keep sending the "Authorization: Basic TOKEN" header. This was the case before commit 235f6e1.
Since commit 235f6e1, that Authorization header is only sent for the initial connection to "/" and not for subsequent completion requests. Instead, it gets overwritten with "Authorization: undefined".
The symptom is that all completion requests fail. The never reach the server. See the screenshots below. The main difference is at the bottom right under "Request headers" (Authorization).
I understand that 235f6e1 uses a new kind of completion requests which I'm not too familiar with. Please let me know if there's any further information I can provide to help diagnose this issue.
Cheers.
First Bad Commit
235f6e1
Relevant log output
No response
The text was updated successfully, but these errors were encountered: