MiniCPM: fix for gpa #7967
Open
MiniCPM: fix for gpa #7967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zkh2016
commented
Jun 17, 2024
zkh2016
commented
- I have read the contributing guidelines
- Self-reported review complexity:
- Low
- Medium
- High
compilade
reviewed
Jun 17, 2024
| @@ -1547,7 +1547,7 @@ def set_vocab(self): | |||
|
|
|||
| def _reverse_hf_permute(self, weights: Tensor, n_head: int, n_kv_head: int | None = None) -> Tensor: | |||
| if n_kv_head is not None and n_head != n_kv_head: | |||
| n_head //= n_kv_head | |||
| n_head = n_kv_head | |||
There was a problem hiding this comment.
This makes MiniCPMModel._reverse_hf_permute exactly equivalent to LlamaModel.permute. Should LlamaModel.permute (which is also a static method) be used instead in MiniCPMModel?
compilade
added
the
Review Complexity : Low
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.