CMake: CMakePresets fix, host for msvc compiler can only be x86 or x64 #8624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xarbirus
changed the title
ggerganov
approved these changes
Jul 22, 2024
Xarbirus
force-pushed
the
cmake-presets-fix
branch
from
a968e50 to
9bb6fd4
Compare
mofosyne
added
Review Complexity : Low
Xarbirus
force-pushed
the
cmake-presets-fix
branch
from
9bb6fd4 to
3a2190b
Compare
|
I would like to know if this request will be merged? Do I need to do something for this? |
|
Sorry, not many people are working with visual studio and this probably got forgotten. The changes look good to me. |
slaren
approved these changes
Sep 5, 2024
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the CMake documentation, the host value for the MSVC compiler in the toolchain can be x86 or x64.