make : use C compiler to build metal embed object #8899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
commented
Aug 7, 2024
Makefile
Outdated
| @echo ".globl _ggml_metallib_end" >> $(TEMP_ASSEMBLY)/ggml-metal-embed.s | ||
| @echo "_ggml_metallib_end:" >> $(TEMP_ASSEMBLY)/ggml-metal-embed.s | ||
| $(CC) $(CFLAGS) -c $(TEMP_ASSEMBLY)/ggml-metal-embed.s -o $@ | ||
| @rm -fr ${TEMP_ASSEMBLY} |
There was a problem hiding this comment.
Hopefully this will not turn into rm -fr / if something goes wrong, but I am open to suggestions for a better way to do this.
There was a problem hiding this comment.
Does a simple string length check work? (I'm not sure if the code below is valid in makefile)
$( [ "$TEMP_ASSEMBLY" -lt 6 ] && exit 1 )
There was a problem hiding this comment.
I have split this into a rm to delete the file, and a rmdir to delete the directory. This way, we don't need to use -r with rm, which should be a bit safer.
ggerganov
approved these changes
Aug 7, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* make : use C compiler to build metal embed object * use rm + rmdir to avoid -r flag in rm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #8211
In some cases, the assembler seems to build the object for the wrong architecture.
cmakeuses the C compiler to build this file, so doing the same in theMakefilemay fix it.