Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi valued library selection #176

Open
PMenges opened this issue Jan 30, 2025 · 3 comments
Open

Multi valued library selection #176

PMenges opened this issue Jan 30, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@PMenges
Copy link
Member

PMenges commented Jan 30, 2025

Is your feature request related to a problem? Please describe.
High number of smilar-ish methods for library selection leads maintenance overhead + high granularity. With too similar values the CV has little value over free text.

Describe the solution you'd like
Multi instead of single value, meaningful selection of terms that can be combined to describe the used library selection method

Describe alternatives you've considered

  • Free text, not ideal
  • Steadily expanded CV, not scalable
@PMenges PMenges added the enhancement New feature or request label Jan 30, 2025
@M-casado
Copy link

May I suggest using EFO's ontology (either directly for validation, or by copying their terms)

@mauerk
Copy link
Member

mauerk commented Feb 7, 2025

Hi @M-casado , thanks for the suggestion. That would definitely be a suitable candidate for our library preparation property.
Is this ontology term also part of the EGA schema? If yes, how do you handle the varying granularity between the terms (86 subterms for single cell library construction, none for cDNA or DNA library construction)?

@M-casado
Copy link

Hi @mauerk, for what I remember, it's not yet included in the library preparation, but it will definitely be at some point. In similar cases of varying granularity we either:

  • Only registered a "high" hierarchy term (e.g., the 6 terms right below the library preparation)
  • Allowed for any term "below" another term to be provided. For example, if given EFO:0030009, we would simply check (through Biovalidator) if that CURIE is encompassed by the library preparation term (OBI:0000711). This was done through the graphRestriction constraint.

This way, if we wanted to know just an overarching classification, we did the former; but if more granularity was available or expected, we choose the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants