Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that admin changes made to sample 'species' and 'sample ID' are not saved #2088

Open
molcretb opened this issue Nov 8, 2024 · 4 comments

Comments

@molcretb
Copy link

molcretb commented Nov 8, 2024

User story

As a curator
I want to be able to modify the sample 'species' and 'sample ID' fields in the 'Update sample' window
So that the changes are saved

Acceptance criteria

Given I am on a dataset admin page e.g. https://gigadb.org/adminSample/update/id/187935
When I modify the fields 'Species *' or 'Sample ID' AND click to the 'Save' button
Then the modifications are saved AND I can see the new values in the Sample admin browser e.g. https://gigadb.org/adminSample/admin

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Admin/Samples' and search sample ID 'test_for_bug_Species_sampleID_tryToRemoveThis'
  2. Click on 'update'
  3. Remove the '_tryToRemoveThis' part of the Sample ID field and click on 'Save'
  4. See error (modification is not saved)

Expected behavior

I want the modified fields 'Species' and 'Sample ID' to be saved after modification.

Screenshots

Image
Image
Image

Desktop (please complete the following information):

  • OS: Windows10
  • Browser chrome
  • Version 130.0.6723.92

Additional context
Add any other context about the problem here.

@alli83
Copy link
Collaborator

alli83 commented Nov 18, 2024

fix in PR #1995

@tuli
Copy link

tuli commented Dec 5, 2024

@only1chunts can you clarify the status of this fix? I have a Species I need to update in a sample, but am unable to do so.
Do I need to ask Tech to fix it? https://gigadb.org/adminSample/update/id/188956 Current - 291826:Elopichthys bambus, Should be 238031:Elopichthys bambusa
291826 is Xenocypris davidi which is what is showing in the mockup https://gigadb.org/dataset/102615/token/DsWoUBLw3g6Ouz8V

@only1chunts
Copy link
Member

this fix has not been deployed yet so you will not be able to change the species until it has been.
The work around is to create a new sample with the correct details and then delete the wrong one (do not change the species name in the species table as that will then be incongruent with the NCBI taxon)

@alli83
Copy link
Collaborator

alli83 commented Dec 8, 2024

#1995 (review)

@alli83 alli83 moved this from Tasks To Do to 👷 Work In Progress 👷‍♀️ in Sprint 28 Backlog 14/08 - 04/09/2024 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👷 Work In Progress 👷‍♀️
Development

No branches or pull requests

7 participants