Memory Leak from SingleFile

[artiste212]

There is a memory leak in SingleFile1.1.126

When I save a web page, not only does Activity Monitor doesn’t show increased RAM usage by Singlefile, but other websites increase their usage to over 1Gb. SingleFile works fine otherwise.

To reproduce;

1. Go to website ex. https://forums.realgm.com/boards/viewtopic.php?p=109531660#p109531660
2. Download the page using SingleFile
3. Look at activity monitor for SingleFile
4. Activty monitor shows "Forums.realgm.com" using 1.3 Gb memory. I've posted a screenshot of Activity Monitor. When I uncheck SingleFile in Safari Settings > Extensions, I can close the web page and reopen without any problems involving memory usage. Also, I used Speedometer 2.1 and saw a significant slowdown in Safari's speed (but don't know how this benchmark compares to real world functioning).

Expected behavior is that memory is released after using Single File.

Environment

• OS: macOS 14.1.1
• Browser:Safari
• Version 17.1

Thanks.

[gildas-lormeau]

I tried to reproduce your issue but I did not see any issue related to a memory leak on my end. Did you change any settings in SingleFile? Do you have other extensions installed which might somehow cause this leak when SingleFile is installed?

[artiste212]

Hi Gildas, Thanks for the reply. I had been using several more extensions, including: Bear, Dynamo, Save to Pocket, Stop the Madness, and Vinegar. I kept only SingleFile and the Wipr ad blocker active, because the bulletin board site is unusable without it. I opened 2 tabs: https://forums.realgm.com/boards/viewtopic.php?p=109553677#p109553677 and https://www.nytimes.com/2023/11/28/us/politics/biden-israel-hamas-divisions.html. I saved the NYTimes tab with SingleFile using no settings changes, and then opened the .html file it created. I then closed the .html file. The memory usage on both tabs doubled. The RealGm site had gone from under 400 Mb to 741, and the NYTimes site increased from around 370Mb to 619 Mb, as per the picture below. When I closed it, the memory that was used by NYTimes.com stayed in the cache. So instead of having around a total of 775 Mb used, it was well over 1.3Gb. Later on, when I closed the entire Safari window, the memory did get released. This is the activity monitor window:  I realize how hard it is to look for memory usage with multiple extensions open. I believe the memory usage issue showed up when I loaded the .html file created by SingleFile, so I will not open it until it’s needed. That may help. Thanks again for looking at this. Bruce

…

On Nov 27, 2023, at 8:03 AM, Gildas ***@***.***> wrote: I tried to reproduce your issue but I did not see any issue related to a memory leak on my end. Did you change any settings in SingleFile? Do you have other extensions installed which might somehow cause this leak when SingleFile is installed? — Reply to this email directly, view it on GitHub <#1321 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD57BJRAVF6N5CBVB2G7U5LYGSFQNAVCNFSM6AAAAAA73KLSWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRXG44TGOJUHA>. You are receiving this because you authored the thread.

[see2ever]

I've notice same problem, even I didn't use singlefile to export webpage, just enable it, and scroll the page, enter & exit the detail page, the memory won't release;

for example:

https://debank.com

[gildas-lormeau]

@see2ever I did a test on https://debank.com/profile/0x33eecc48943aaeabb5328a25ff28eb85f67945c2/stream but I cannot reproduce the issue.

[freemedom]

my problem is that when i save a site(very long contents), commited memory is too much (about 10-15GB to windows page file). but the file downloaded may be only about 10MB.
OS: windows10
Browser: Chrome

(i later save this site using the ctrl+s, and save a 12MB mhtml file.)

[freemedom]

gildas-lormeau/SingleFileZ#42